feat: add modulo operator #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
dermitzos
force-pushed
the
feat/add-modulo-operator
branch
from
c7a4c41 to
a15f659
Compare
dermitzos
force-pushed
the
feat/add-modulo-operator
branch
from
72e0613 to
df88b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the modulo (
%) and modulo assignment (%=) operators in the Arcscript language implementation. It updates the grammar, interpreter logic, and test coverage to handle these operators, including correct runtime error handling for invalid operations like division by zero.Grammar and Parser Enhancements:
MOD(%) andASSIGNMOD(%=) tokens toArcscriptLexer.g4and updatedArcscriptParser.g4to support modulo and modulo assignment in expressions and assignments. [1] [2] [3]Interpreter Logic Updates:
ArcscriptVisitor.jsto evaluate modulo and modulo assignment operations, including error checking for division by zero. [1] [2] [3] [4]Test Coverage Improvements:
%and%=operators tovalid.jsonandruntimeErrors.json. [1] [2]